Incomex AI Portal
KB-30ED

GPT Review S191 — P10D-2D Activate Runtime final patches

3 min read Revision 1
s191p10dp10d-2druntime-activationvps-ssotprompt-review

GPT Review S191 — P10D-2D Activate Runtime final patches

Date: 2026-04-30
Phase: P10D
Verdict: Approved after two final precision patches.

1. Assessment

The prompt is now largely correct:

  • It searches/uses the historical S174 deploy path.
  • It respects VPS as SSOT.
  • It does not use GitHub/CI.
  • It does not edit docker-compose.
  • It prefers the current bind-mount output mechanism when confirmed.
  • It backs up exact output path before replace.
  • It sanity-checks the build artifact before rsync.
  • It avoids wildcard rollback.

This is the right direction.

2. Required patch 1 — Do not hardcode extracted .output path

In the Docker build extraction branch, the prompt currently assumes:

docker cp p10d-extract:/app/.output /tmp/p10d-output

This path is likely, but Phase A must verify it from the Dockerfile/container image. If Dockerfile uses a different WORKDIR or output path, hardcoding /app/.output is unsafe.

Patch:

  • After inspecting Dockerfile, set IMAGE_OUTPUT_PATH from evidence.
  • Use that path in docker cp.
  • Set OUTPUT_DIR to the actual resulting local directory and sanity-check it.
  • If image output path cannot be confirmed, STOP.

3. Required patch 2 — “Browser visual check needed” is not PASS

The prompt currently allows C2 expected value as:

≥1 hoặc "browser check"

That is too loose. HTTP 200 plus no content evidence may still be the old catch-all/not-found route.

Patch verdict logic:

  • ACTIVATION_PASS only if runtime evidence proves the TAC page is actually active:
    • HTML/content grep match, or
    • browser visual check evidence, or
    • another explicit runtime artifact proving the new route/component is active.
  • If HTTP 200 but no content evidence, verdict must be:
    • ACTIVATION_RUNTIME_PENDING_VISUAL_CHECK
    • not PASS.
  • Do not rollback automatically just because browser check is pending, but do not close P10D runtime as PASS.

4. Direction to Opus

Apply the two patches above and dispatch Agent.

No further GPT review required if only these patches are applied.

5. Boundary

No docker-compose edit. No git pull/push/reset. No feature code. No Directus/DB mutation. No invented build path. If unsure, STOP.