KB-3721

GPT Review S190 — P10B-2C-R2-FOLLOWUP prompt approved after two small patches

3 min read Revision 1
s190p10bd28followuprender-diffprompt-reviewapproved-after-patches

GPT Review S190 — P10B-2C-R2-FOLLOWUP prompt

Date: 2026-04-30
Phase: TAC MVP / P10B / D28
Verdict: APPROVED AFTER TWO SMALL PATCHES


1. Law / constitution check

Checked against current constraints and recent decisions:

  • VPS remains runtime/DB SSOT, accessed through verified SSH.
  • KB remains artifact/report SSOT.
  • No additional DB mutation is authorized after Execute R2 commit.
  • No rollback is authorized.
  • No DDL/DML is allowed in the follow-up.
  • Deliverables must go to KB through Agent Data / KB API only, not direct kb_documents mutation.
  • Renderer must not become section-specific/case-dispatch logic.

No constitutional conflict was found if the two patches below are applied.


2. Assessment

The follow-up prompt is correct in scope:

  • It confirms committed D28 state.
  • It runs the corrected uv.lifecycle_status query.
  • It uses verified render.sql and original source SHA.
  • It renders, diffs, writes tree report, documents rollback instructions only, and stops.
  • It does not close out P10B.

3. Required small patches

Patch 1 — KB upload method must be explicit

In T8, add:

Upload follow-up report and deliverables to KB using Agent Data / KB API only. Do not INSERT/UPDATE directly into kb_documents and do not use SQL against KB tables.

Reason: Red Zone explicitly prohibits manual kb_documents mutation.

Patch 2 — Render failure must not fall through to clean/diff PASS

T4 currently says continue to T8 if render failed, but the prompt does not explicitly say to skip T5–T7.

Add:

If render command fails or /tmp/p10b-2c-r2-followup/d28-render-raw.tsv is missing/empty, do not run clean render, diff, or tree PASS assertions. Create a FAIL follow-up report with all available logs/artifacts, upload to KB, and STOP.

Also prefer running the pipefail block under bash to avoid Mac zsh shell differences:

bash -lc 'set -o pipefail; ssh contabo '\''docker exec -i postgres psql -U directus -d directus -X -A -F"|" < /tmp/d28-render.sql'\'' 2>&1 | tee /tmp/p10b-2c-r2-followup/d28-render-raw.tsv; exit ${PIPESTATUS[0]}'
rstatus=$?
if [ "$rstatus" -ne 0 ]; then
  echo "RENDER FAILED with status=$rstatus. Upload failure report/logs only."
  touch /tmp/p10b-2c-r2-followup/RENDER_FAILED
fi

If RENDER_FAILED exists, skip T5–T7 and go to T8 failure report/upload.


4. Direction

After applying exactly these two patches, Opus may dispatch the follow-up directly. No additional GPT review is required if scope is not broadened.


5. Boundary

No additional INSERT/UPDATE/DELETE/DDL is authorized. No rollback. No P10B closeout in this follow-up.