GPT Review S189 — P10B-2B-FIX-REGEN-PROMOTE v2 prompt approved after minor patches
GPT Review S189 — P10B-2B-FIX-REGEN-PROMOTE v2 prompt
Date: 2026-04-29
Phase: TAC MVP / P10B / D28 in progress
Verdict: APPROVED AFTER MINOR PATCHES
1. Overall assessment
The v2 prompt correctly implements the S189 infrastructure decision:
- Agent may run on Mac.
- VPS remains runtime/DB SSOT.
- Runtime/DB checks go through
ssh contabo. - KB remains artifact/report SSOT.
- KB upload must use Agent Data / KB API only.
- No D28 execute, no PF-R2 in this step.
/tmpis local workspace only.
The prompt is close enough to run after the patches below.
2. Required patches before run
Patch 1 — Change authorization banner wording
Current:
GPT AUTHORIZED — execute immediately
Risk: ambiguous after repeated “do not execute D28” discipline.
Replace with:
GPT AUTHORIZED — run this READ-ONLY REGEN-PROMOTE step immediately. Do not execute D28 SQL.
Patch 2 — Do not generate INSERT column list by blindly using all T3 schema columns
Current T5 says:
Column list from T3 schema
Risk: Agent may include default/generated/audit columns that should not be inserted manually.
Replace with:
Use explicit known-safe INSERT column lists from the prior PASS packages, then verify every chosen column exists in T3 schema. Do not blindly insert all information_schema columns. Exclude generated/default/audit columns unless previous PASS package already used them and schema verification confirms they are required.
Patch 3 — Fix destructive SQL scan wording
Current T6 says:
Destructive scan (sanitized): 0 on real tables
Risk: rollback.sql intentionally contains scoped DELETE, so scanning all generated files for zero destructive SQL would false-fail or encourage removal of rollback.
Replace with:
Destructive scan:
insert-candidate.sql,render.sql,verify-counts.sql: no DELETE/TRUNCATE/DROP/ALTER/UPDATE against real TAC tables.rollback.sql: DELETE allowed only if reverse-FK order and scoped strictly to DIEU-28/v2.0/canonical prefix. No unscoped DELETE, no TRUNCATE, no DROP, no ALTER.
Patch 4 — Clarify Gate 0 DB identity expected output
Add under Gate 0 PASS conditions:
Trim whitespace before comparing DB identity. Expected value is exactly
directus/directus.
Patch 5 — Manifest files list must include helpers if generated
Current manifest list mentions gen.py but T8 says helpers may exist.
Add:
Include every helper script actually used in the manifest and KB upload/read-back set. No generated helper may remain only in
/tmp.
3. Non-blocking notes
- T13 Đ41 hygiene is acceptable as read-only.
- T2 birth-gate matrix wording is good. Blocking gates must all PASS. Non-blocking observations may be reported separately, but must not be hidden.
- Mac-local generation is acceptable under S189 as long as KB inputs are canonical and DB/runtime introspection comes through SSH to VPS.
4. Final direction to Opus/User
Apply the 5 patches above, then run the prompt.
Do not run PF-R2 and do not execute D28 SQL until REGEN-PROMOTE returns PASS with KB manifest and read-back verification.