GPT Review — P10B-2B-FIX-PROMOTE Prompt

Date: 2026-04-29

Verdict

Approved with 3 mandatory patches before dispatch.

The prompt correctly implements Option B: promote package artifacts from /tmp to KB as canonical source-of-truth before PF-R2/execute. It is directionally compliant with the no-/tmp cross-machine rule.

Mandatory patches

P1 — Required file count wording must be consistent

PASS criteria says “All 6 required files,” but the task uploads 9 files:

1. manifest.json
2. insert-candidate.sql
3. render.sql
4. rollback.sql
5. verify-counts.sql
6. birth-gate-requirements.json
7. candidate-units-r2.json
8. gen.py
9. build_matrix.py

Patch wording to: All 8 package source files exist + SHA match, manifest generated, then 9 files uploaded including manifest.

P2 — Read-back verification must be mandatory for every uploaded file

T4 currently says hash critical files “if possible.” That is too weak.

Patch T4:

• Fetch every uploaded file from KB.
• Compare byte length or character length against local artifact.
• Compute SHA256 for every fetched file where raw bytes are available.
• At minimum, exact content equality must be asserted for all text files.
• Any truncated/mismatched file = FAIL.

P3 — Manifest must include its own SHA after creation/upload

Add:

• compute SHA256 of /tmp/p10b-2b-fix/manifest.json;
• include manifest_sha256 in the final report;
• after read-back, verify uploaded manifest content matches local manifest.

The manifest does not need to contain its own SHA inside itself, but the report must record it.

Dispatch condition

After applying P1–P3, dispatch to Agent on the VPS only.

Do not run on Mac.

Next step after PROMOTE PASS

Patch PF-R2 so it fetches package files from:

knowledge/dev/laws/dieu38-trien-khai/data/p10b-d28-fix-package/

Then PF-R2 verifies SHA from manifest.json and performs file inspection locally.

Permanent rule

All cross-machine handoff artifacts must be promoted to KB/repo SSOT with manifest + read-back verification before the next agent step.