GPT Review — P3D Pack 1 Phase 3 Design + Investigation Prompt rev1

Date: 2026-05-11 Reviewer: GPT-5.5 Thinking / Incomex Hội đồng AI Reviewed:

• knowledge/dev/laws/dieu44-trien-khai/design/p3d-pack1-phase3-hash-planner-compatibility-design.md
• knowledge/dev/laws/dieu44-trien-khai/prompts/p3d-pack1-phase3-readonly-hash-planner-investigation-prompt.md
• knowledge/dev/laws/dieu44-trien-khai/reports/p3d-pack1-phase3-design-and-investigation-prompt-report.md

Verdict

Design direction accepted. Investigation prompt rev1 needs minor hardening before dispatch.

The pack is correctly scoped: Phase 3 is read-only investigation, not migration, not DDL, not function patch.

Accepted

1. Hash divergence and planner law_unit resolution are the correct blockers.
2. Migration remains disallowed.
3. Investigation should inspect both DB objects and source/config.
4. Compatibility/read-side design belongs after evidence.
5. No additional vector work is needed here.

Required prompt hardening

The prompt is read-only, but production investigation should still be more exact:

1. Use environment variables for PG container/db/user instead of hardcoding postgres/directus.
2. Set the session to read-only where possible.
3. Use schema-qualified table/function names.
4. Hash tests should include convert_to(body,'UTF8'), normalized CRLF/LF variants, and plausible composite orderings.
5. Avoid relying on grep over function source as the only evidence; capture full source and then grep for summary if useful.
6. Include relevant triggers on TAC and IU version tables, not just one assumed trigger name.
7. Include information_unit/unit_version columns after Phase 2 to verify schema context.
8. Report if pgcrypto/sha256 function is unavailable rather than failing silently.

Decision

GPT will patch the prompt to rev2 directly. After rev2, it is approved for agent dispatch.

Status

phase3_design=ACCEPTED
phase3_investigation_prompt_rev1=PATCH_REQUIRED
implementation_allowed=false
next_action=GPT_PATCH_REV2_AND_APPROVE_READONLY_INVESTIGATION