GPT Review — P3D Birth System Completion v2: Design OK Directionally; Inventory Prompt Not Approved

Date: 2026-05-12 Reviewer: GPT-5.5 Thinking / Incomex Hội đồng AI Reviewed:

• knowledge/dev/laws/dieu44-trien-khai/design/p3d-birth-system-completion-architecture-design.md rev2
• knowledge/dev/laws/dieu44-trien-khai/prompts/p3d-birth-system-completion-readonly-inventory-prompt-DRAFT.md rev1
• knowledge/dev/laws/dieu44-trien-khai/design/p3d-birth-system-completion-roadmap.md rev2
• knowledge/dev/laws/dieu44-trien-khai/reports/p3d-birth-system-completion-design-and-inventory-prompt-report.md rev2

Verdict

Birth System Completion design v2 is accepted directionally.

Read-only inventory prompt rev1 is NOT approved for Agent dispatch.

The design framing is correct: birth is not broken; completion is extension, not replacement. However, the inventory prompt still contains hardcode / hardcode-by-pattern that is not acceptable, especially because this inventory is meant to determine the true runtime state.

What is accepted

1. Birth is NOT broken — completion is extension, not replacement is the correct framing.
2. Required-at-birth vs hook-at-birth vs enriched-later classification is correct.
3. Governing rule is correct:

No new production object creation/migration pack shall proceed unless birth metadata minimum contract is satisfied or explicitly waived by GPT/User.

4. Roadmap B0 → B6 is the correct sequence.
5. Phase 5C2 remains paused.
6. Existing TAC→UI must be preserved.
7. Birth engine should stay light but not incomplete.

Design v2 corrections needed before final approval

1. Avoid “same as v1” inside foundational design

Design sections I and L contain:

(Same as v1 ...)

A foundational design must be self-contained. Patch these sections to inline the actual content or mark them explicitly as NEEDS_SOURCE_EXPANSION.

2. Do not overclaim direct evidence in design

Design says fn_birth_registry_auto fires on 30+ tables and 15,307+ births recorded based on prior reports. It is acceptable as historical evidence, but the design should label these as:

prior evidence, to be re-verified by inventory

not current immutable truth.

Inventory prompt blockers

1. Same pattern as TAC→UI baseline rev3 is not dispatchable

The prompt says:

Same pattern as TAC→UI baseline rev3 Phase 0

A dispatch prompt must be self-contained. Agent must not need to remember another prompt.

Required: inline the environment/DB discovery steps.

2. db_schema = public is hardcoded as a scope constant

The prompt says:

db_schema = public (verify via discovery)

Better:

db_schema = DISCOVER; public is historical expectation only, not execution truth.

Do not use public in executable SQL until schema is resolved.

3. Table names are used before table existence resolution

The prompt uses:

birth_registry
species_collection_map
entity_species
collection_registry
information_unit
unit_version
entity_dependencies
entity_labels
universal_edges
event_outbox
pivot_definitions

These may be valid target families, but existence must be verified first. Use a table-family registry and live table resolution before queries.

4. Column placeholders appear in executable-looking SQL

The prompt has SQL such as:

SELECT count(*) FILTER (WHERE <species_col> IS NOT NULL)
SELECT <collection_col>, count(*) FROM birth_registry GROUP BY 1
SELECT * FROM species_collection_map ORDER BY <collection_col>

This is a pattern, but it is not labelled strongly enough. Agent may copy/fill by memory.

Required: all such SQL must be under PATTERN ONLY — compile executable SQL only after table + concept resolution.

5. Concept resolution is missing

The inventory prompt needs a concept registry for the fields it needs, at minimum:

birth_pk
birth_collection_key
birth_entity_ref
birth_species_identifier
birth_composition_identifier
birth_created_at
birth_actor
birth_governance_state
birth_lifecycle_state
birth_owner_ref
birth_provenance_ref
species_pk
species_code
species_composition
mapping_collection_key
mapping_species_ref
mapping_is_primary
collection_key
collection_governance_role
collection_migration_state

Each concept must have:

semantic hints / candidate labels
required_for
resolution rule
on unresolved behavior

6. Function source queries are too broad

Prompt asks for full pg_get_functiondef for several functions. That may be acceptable, but report should summarize bounded facts and avoid dumping huge definitions unless necessary.

Add bounded output rules:

record signature/return type; summarize write targets/checks; include excerpt lines only if needed; store full function source in report appendix if length manageable.

7. Sample of 10 governed collections is not safe without deterministic selection

Prompt says sample 10 governed collections. It must define deterministic selection:

all governed if count <= threshold; otherwise order by stable key and take first N, plus all IU/TAC families.

Do not random sample.

8. Final report missing classification matrix

Final output should include counts for the classifications from design:

required_at_birth_supported_count
required_at_birth_unknown_count
required_hook_supported_count
required_hook_unknown_count
enriched_later_hook_supported_count

Required next action

Patch inventory prompt rev1 → rev2 and patch small design wording issues.

Open:

P3D_BIRTH_SYSTEM_COMPLETION_INVENTORY_PROMPT_REV2_DISCOVERY_FIRST

Status

birth_design_v2=ACCEPTED_DIRECTIONALLY
inventory_prompt_rev1=NOT_APPROVED_FOR_DISPATCH
reason=hardcode_by_pattern_missing_concept_resolution
phase5c2_migration_allowed=false
agent_dispatch_allowed=false
next_action=OPUS_PATCH_BIRTH_INVENTORY_PROMPT_REV2