GPT Review — B3-F1c-c Line Review Follow-up — PATCH REQUIRED BEFORE AGENT — 2026-05-13

Scope reviewed

Reviewed Opus line-by-line constitutional report and current scheduler artifacts:

• knowledge/dev/laws/dieu44-trien-khai/reviews/opus-line-by-line-review-b3f1c-c-scheduler-no-hardcode-2026-05-13.md
• knowledge/dev/laws/dieu44-trien-khai/design/p3d-birth-system-b3f1c-c-directus-nuxt-dot-scheduler-design.md
• knowledge/dev/laws/dieu44-trien-khai/prompts/p3d-birth-system-b3f1c-c-scheduler-shape-probe-and-artifact-prompt-DRAFT.md
• knowledge/dev/laws/dieu44-trien-khai/reports/p3d-birth-system-b3f1c-c-scheduler-design-report.md

Verdict

Status: PATCH_REQUIRED_BEFORE_AGENT_PROBE

GPT agrees with Opus that there are no architectural blockers, but the current documents still contain hardcode-risk wording and future-execution ambiguity. Because the user explicitly requested no silent patching at this stage, GPT is not patching documents directly. Opus must revise and return an updated report before Agent dispatch.

Required patches before Agent probe

1. Observability candidate values must be qualified in the design

Current design states concrete values:

issue_type: BIRTH_FULL_SCAN_RUN_SUMMARY
severity: informational / critical
entity_ref: birth_onboarding_full_scan
details: full JSONB from function return

Required revision:

• Mark all of these as candidates, not truth.
• State that actual column names, issue type/sub_class, severity vocabulary, entity fields, status, and JSON/details support must be derived from live system_issues shape and existing conventions.
• If unsupported, Agent must return PARTIAL/BLOCKED and not invent fields.

2. Define fallback if system_issues lacks JSONB/details support

Current design asks whether a details/details_json column exists, but does not define the acceptable fallback.

Required revision:

• If structured JSONB storage is absent, either:
  1. compile text-only summary with observability_status=PARTIAL, or
  2. mark BLOCKED_FOR_OBSERVABILITY_DECISION.
• Do not create a new table or column in this phase.
• Do not pretend text-only summary is equivalent to durable structured observability.

3. Prompt §6c cadence must mirror §6b candidate wording

Current prompt §6c still says:

policy.birth_full_scan.cadence_cron = 0 */6 * * *

Required revision:

• State that this is a candidate only if no existing cadence policy is found.
• Mark the artifact with candidate_cadence_requires_review=true or equivalent.
• Ensure dot_config policy seed and Directus Flow seed derive from the same reviewed cadence candidate.

4. Directus Flow pattern failure must BLOCK, not infer

Current prompt says use exact pattern discovered from [DOT-REG] Count Refresh, but does not explicitly block if the pattern is undiscoverable or non-generalizable.

Required revision:

• Add explicit branch:

If a safe Directus Flow + Operation pattern cannot be discovered from live scheduled flows, mark directus_flow_seed_compiled=false and b3f1c_c_probe_status=PARTIAL|BLOCKED with reason BLOCKED_PATTERN_UNDISCOVERABLE. Do not compile from assumptions.

5. Future execution section must not imply unapproved manual test call or git commit

Design §G future execution says:

Agent verifies: flow active, endpoint responds, manual test call
Git commit

Risk:

• Manual test call may invoke fn_birth_onboarding_full_scan() and write system_issues.
• Git commit is outside the scheduler seed unless explicitly reviewed.

Required revision:

• Mark these as future execution-candidate actions requiring separate GPT/user approval.
• State that a function/endpoint invocation test is DML-affecting and cannot be assumed harmless.
• State that git commit requires explicit instruction and should not be assumed in the scheduler execution prompt.

6. Design risk row still says “accept simpler approach”

Current design/report contains cadence drift language implying the earlier rejected simplified path.

Required revision:

• Replace with:

Initial seed must derive Directus Flow cron from reviewed policy/candidate. Drift enforcement is future health check. No unsynchronized creation allowed.

7. Diagram URL should be less concrete

Current design diagram still foregrounds:

POST → http://localhost:3000/api/birth/onboarding/full-scan

This is not a blocker if clearly candidate, but it should be rewritten to avoid anchoring Agent.

Required revision:

POST → <DISCOVERED_INTERNAL_URL>/<DISCOVERED_OR_REVIEWED_ENDPOINT_PATH>

with the candidate endpoint path listed separately as candidate.

Governance interpretation

The high-level architecture remains acceptable:

Directus Flow → Nuxt endpoint → public.fn_birth_onboarding_full_scan()
DOT governance via dot_tools
dot_config policy/cadence/kill switch
system_issues or approved alternative for observability

But the current documents are not yet safe enough to hand to Agent because several lines can still be read as runtime truth or future execution authorization.

Required Opus response

Opus should revise the current design/prompt/report and return:

b3f1c_c_constitutional_patch_status=PASS|PARTIAL|BLOCKED
all_pre_probe_patches_applied=true|false
observability_candidates_qualified=true|false
observability_fallback_defined=true|false
cadence_candidate_qualified_in_prompt=true|false
flow_pattern_undiscoverable_blocks=true|false
future_manual_test_and_git_commit_marked_requires_approval=true|false
simpler_approach_removed=true|false
diagram_url_deanchored=true|false
agent_probe_allowed=false_until_gpt_review
next_recommended_action=GPT_REVIEW_PATCHED_B3F1C_C_DOCS

Governance status

b3f1c_c_line_followup_review_status=PATCH_REQUIRED_BEFORE_AGENT_PROBE
agent_probe_allowed=false
scheduler_execution_allowed=false
directus_flow_creation_allowed=false
nuxt_endpoint_creation_allowed=false
dot_config_mutation_allowed=false
dot_tools_mutation_allowed=false
b3f_complete_allowed=false
phase5c2_migration_allowed=false
next_recommended_action=OPUS_PATCH_B3F1C_C_DOCS_PER_GPT_REVIEW