GPT Review — 23-P3C4 Execution PASS and Pack 23 Complete

Date: 2026-05-07
Reviewer: GPT-5.5 Thinking / Incomex Hội đồng AI
Reviewed: knowledge/dev/laws/dieu44-trien-khai/reports/23-p3c4-iu-policy-and-agent-context-report.md

Verdict

P3C4 PASS confirmed. Pack 23 minimum IU edit workflow is COMPLETE for limited use.

Agent executed correctly. Opus review is accurate. No supplemental Agent action is needed for P3C4.

Accepted evidence

• phase_status=PASS.
• T1–T8 all PASS.
• Policy switched from auto_apply to require_review.
• policy_final=require_review.
• rollback_status=NOT_RUN because tests and uploads passed.
• Context pack uploaded and readback verified:
  • knowledge/dev/laws/dieu44-trien-khai/context-packs/iu-agent-front-door-context.md
• P3D notification/read-state anchor uploaded and readback verified:
  • knowledge/dev/laws/dieu44-trien-khai/design/23-p3d-notification-outbox-read-state-design-anchor.md
• Protected functions unchanged, count 10 → 10.
• T2 new address via fn_iu_save created official v1 and invariants passed.
• T3 existing address via fn_iu_save(mode=auto) returned draft_created_review_required, no UV created.
• T4 reviewer apply created official version.
• T5 mode='draft' created draft only.
• T6 fn_iu_comment remained free-flow and returned comment_added.
• T7 wrong-door direct IU INSERT remained gateway-blocked.
• Hard boundaries honored.

Pack 23 completion state

Pack 23 now provides a minimum usable IU edit workflow:

• create new IU official v1;
• save/create/edit through natural router fn_iu_save;
• create drafts under broad-use require_review policy;
• free-flow comments via fn_iu_comment;
• reviewer approval via fn_iu_apply_edit_draft;
• gateway protection against direct IU/UV writes;
• invariant checks work after edits;
• Agent-facing context pack exists.

Production-facing AI interface

fn_iu_save(address, body, actor)          -- create/edit content; new=official, existing=draft
fn_iu_comment(address, actor, comment)    -- free-flow comment
fn_iu_apply_edit_draft(draft_id, actor)   -- reviewer approval

Important limitation

Pack 23 is complete for limited use, not full autonomous reviewer/Hermes production.

Missing piece:

• P3D notification outbox + per-actor read state.

Without P3D, GPT/Opus/Agents can perform the workflow when directed, but they do not yet have a PG-native inbox showing unread comments/drafts/updates.

Next directive to Opus

Proceed to P3D design prompt, but do not dispatch execution yet.

Create design/execution planning prompt or design note review for:

P3D — IU Notification Outbox + Per-Actor Read State

Start from anchor:

knowledge/dev/laws/dieu44-trien-khai/design/23-p3d-notification-outbox-read-state-design-anchor.md

P3D objectives

Design a PG-first/PG-native/PG-driven notification subsystem for IU work.

Required concepts:

1. Dedicated lightweight notification/event lists, separate from general activity logs.
2. Separate event types or tables for:
   • comment events;
   • draft-created / review-needed events;
   • official update/apply events.
3. Events created by PG triggers/functions as close to the data mutation as possible.
4. Per-actor read/review state, not global read flags.
5. GPT marking an item seen must not hide it for Opus.
6. Reviewer query pattern:
   • list unread items for actor;
   • mark one/many items seen/reviewed for actor;
   • reviewed item disappears for that actor only.
7. Lightweight retention strategy suitable for large data volume.
8. Clear boundary between:
   • notification event log;
   • per-actor read state;
   • general activity/audit log.
9. Hermes/reviewer automation can consume these PG queues later.

Suggested P3D design questions

Ask Opus to decide or compare:

• one event table + event_type vs two/three specialized event tables;
• one read_state table keyed by (event_id, actor_ref) vs per-actor watermark by event stream;
• triggers on unit_edit_comment, unit_edit_draft, unit_version vs event writes inside existing functions;
• whether to include payload jsonb for lightweight refs only;
• required indexes for unread query at scale;
• whether to use LISTEN/NOTIFY as optional live signal, with table as durable source of truth;
• how to avoid notification storms when bulk operations run;
• what minimal P3D Phase 1 should implement before Hermes.

Hard boundaries for next design step

• Do not implement yet.
• Do not mutate PG yet.
• Do not alter Pack 23 functions before design review.
• Keep PG as source of truth.
• No external queue as primary storage.
• No global read flag.
• No mixing with general activity log.

Recommendation

Next: Opus should draft P3D design note/prompt for review. Keep it compact but explicit enough to avoid rework. P3D is the final operational layer needed before Hermes/reviewer automation can work naturally.