GPT Review — 23-P3C3 Execution PASS and Next Directive

Date: 2026-05-07
Reviewer: GPT-5.5 Thinking / Incomex Hội đồng AI
Reviewed: knowledge/dev/laws/dieu44-trien-khai/reports/23-p3c3-iu-natural-save-router-report.md

Verdict

P3C3 PASS confirmed. No supplemental Agent action needed for P3C3.

Agent executed correctly. Opus review is accurate.

Accepted evidence

• phase_status=PASS.
• T1–T14 all PASS.
• public.fn_iu_save(text,text,text,text,text,text) created and persisted.
• Owner/security correct: owner directus, SECURITY DEFINER, search_path pg_catalog,public, PUBLIC revoked.
• fn_iu_save source check passed: no direct IU/UV writes and no app.canonical_writer marker.
• Protected function set unchanged: count 9 before/after, hashes identical.
• Policy unchanged: iu_edit.policy.default_mode=auto_apply.
• Gateway still blocks wrong-door direct IU write.
• Count deltas match auto-apply policy:
  • IU 8→9 (+1)
  • UV 12→14 (+2)
  • drafts 7→9 (+2)
  • comments 8→10 (+2)
• T1 new address created official IU version 1 and invariant passed.
• T2 mode=draft created draft only, no UV.
• T3 mode=auto applied under current auto_apply policy.
• T4 same body returned no_change.
• T7 free-flow comment succeeded with explicit draft context.

Accepted deviations

Agent made three reasonable test-harness adaptations against live runtime schema:

1. fn_iu_create actual signature has 9 args with defaults. The 4-positional call remains valid and T1 proves it.
2. fn_iu_comment kind changed from note to general to satisfy live validation.
3. fn_iu_comment author_type changed from NULL to agent to satisfy NOT NULL constraint.

These did not alter protected functions or policy, and all boundary checks passed.

Pack 23 current state

Pack 23 now has the minimum usable IU edit workflow:

• create official IU: fn_iu_create;
• create/edit via natural router: fn_iu_save;
• create draft: fn_iu_create_edit_draft;
• comment: fn_iu_comment;
• apply draft: fn_iu_apply_edit_draft;
• edit wrapper/internal convenience: fn_iu_edit;
• invariant works after edits: fn_iu_verify_invariants generalized.

AI-facing operational surface should now be documented as:

fn_iu_save(address, body, actor)         -- create/edit content
fn_iu_comment(address, actor, comment)   -- free-flow comment
fn_iu_apply_edit_draft(draft_id, actor)  -- reviewer approval

Next decision

Do not immediately run a raw one-line UPDATE for policy switch.

Even though the policy switch is technically one dot_config update, it changes production behavior. It should be done as a small reviewed policy pack with verification and a context/README update.

Directive to Opus — create next prompt(s), do not dispatch

Create a compact policy/context pack prompt:

knowledge/dev/laws/dieu44-trien-khai/prompts/23-p3c4-iu-policy-and-agent-context-prompt.md

Report path:

knowledge/dev/laws/dieu44-trien-khai/reports/23-p3c4-iu-policy-and-agent-context-report.md

Objectives

1. Switch broad-use default policy:

   • dot_config.key='iu_edit.policy.default_mode'
   • from auto_apply to require_review.

2. Verify behavior after switch:

   • fn_iu_save(existing_addr, body, actor, ..., mode='auto') creates draft but does not apply;
   • no new unit_version for existing edit under require_review;
   • mode='draft' still creates draft only;
   • new address creation still creates official version 1;
   • fn_iu_comment remains free-flow;
   • wrong-door direct write remains gateway-blocked.

3. Create/update Agent-facing context pack / README:

   • path suggestion: knowledge/dev/laws/dieu44-trien-khai/context-packs/iu-agent-front-door-context.md
   • content should be short and operational:
     • save/create/edit content: fn_iu_save(address, body, actor);
     • comment: fn_iu_comment(address, actor, comment);
     • reviewer approval: fn_iu_apply_edit_draft(draft_id, actor);
     • draft is not official until applied;
     • new IU creation is official version 1;
     • existing IU edits become drafts under broad-use policy;
     • comments are free-flow and do not need approval;
     • direct IU/UV writes are forbidden and gateway-blocked;
     • notification inbox/outbox is deferred to P3D.

4. Record roadmap state:

   • Pack 23 minimum edit workflow is usable after P3C4 PASS;
   • P3D notification outbox remains required before Hermes production.

Required safety

• Preflight current policy must be auto_apply; if not, STOP and report idempotent/already switched state separately.
• Update only the single dot_config key.
• Preserve/update source/hash evidence for fn_iu_save, fn_iu_comment, fn_iu_apply_edit_draft, gateway function.
• No function changes.
• No table DDL.
• No trigger/gateway changes.
• No vector mutation.
• No notification implementation.
• No cleanup/pilot deletion.

Tests required

1. Policy key changed to require_review.
2. Existing address auto save returns draft/review-required and UV count unchanged.
3. Existing address mode=draft returns draft/review-required and UV count unchanged.
4. New address save still creates official IU version 1 and invariant all_pass=true.
5. Comment free-flow works and comment count +1.
6. Direct wrong-door write still gateway-blocked.
7. Protected function hashes unchanged.
8. Context pack/README created/updated in KB.
9. Report includes AI-facing commands and behavior after policy switch.

Why prompt pack instead of one-line update

The policy switch changes the default meaning of fn_iu_save(mode='auto') for existing IUs:

• before: existing content auto-applies;
• after: existing content creates draft awaiting review.

This is exactly the behavior the User wants for safer broad use, but it should be verified and documented in the same step.

After P3C4 PASS

Proceed to P3D notification outbox design/execution before Hermes production.

P3D should create separate lightweight PG-native logs/queues for:

• comment events;
• official update/apply events.

These logs should remain separate from general activity logs and should feed reviewer/Hermes workflows.