GPT Review — 18b-P2 DOT-119 Script Rewrite Prompt rev5

Date: 2026-05-05 Reviewer: GPT-5.5 Thinking / Incomex Hội đồng AI Reviewed:

• knowledge/dev/laws/dieu44-trien-khai/prompts/18b-p2-dot119-script-rewrite-prompt.md rev6 / Rev 5 content
• knowledge/dev/laws/dieu44-trien-khai/design/dot119-v2-script-content.sh rev4 / Rev 5 content

Verdict

Rev5 is very close, but not approved for dispatch. One operational rollback patch is required.

The previous issues were fixed:

• smoke tests now use run_expect for expected non-zero exits;
• synthetic dry-run JSON exposes synthetic_capability=pass;
• prompt remains self-contained;
• no hardcoded function hash;
• no collection/codemapping hardcode;
• no-clobber self-check remains;
• ON_ERROR_STOP=1 is present;
• help/no-args behavior is correct.

Remaining blocker — post-install smoke failure rollback

P2 installs a new core DOT script before smoke tests. If any smoke test fails after install, the system may be left with a broken DOT-119 script.

The prompt currently says “Any STOP → partial report,” but does not explicitly require restoring the v1 backup when post-install smoke tests fail.

For a core tool rewrite, this is not enough.

Required rev6 patch

Patch only the P2 prompt unless Opus wants to add helper comments in the script. The script itself is acceptable.

Add a Post-install failure rollback rule:

1. Define a smoke status accumulator:

SMOKE_FAILED=0

2. For every smoke test, if expected output/exit is wrong:

SMOKE_FAILED=1

3. After all smoke tests, if SMOKE_FAILED=1:

cp "$BACKUP_PATH" "$DOT119"
chmod 755 "$DOT119"
md5sum "$DOT119"
echo "ROLLBACK: restored DOT-119 from $BACKUP_PATH due to smoke failure"
# Upload partial P2 report with all outputs, backup path, failed tests, restored md5.
# HARD STOP.

4. Also restore backup immediately if these critical checks fail after install:

• no-clobber grep unexpectedly non-zero;
• fn_birth_registry_auto hash drift;
• trigger count changed;
• unexpected birth count change clearly caused by P2;
• installed file missing or not executable.

5. Report must include:

• whether rollback happened;
• restored md5 if rollback happened;
• final installed script md5;
• whether final installed script is v1 restored or v2 active.

Optional but recommended

Add a final success statement after all tests pass:

P2 FINAL STATE: v2 active, no rollback, all smoke tests PASS.

Directive to Opus/Ocus

Patch:

knowledge/dev/laws/dieu44-trien-khai/prompts/18b-p2-dot119-script-rewrite-prompt.md

to rev6 with the rollback-on-smoke-failure rule above.

No need to change dot119-v2-script-content.sh unless Opus finds an independent issue.

After rev6, GPT/User can approve dispatch if no new blocker appears.

Hard boundaries remain:

• no fn_birth_registry_auto edit;
• no IU trigger install;
• no IU rows;
• no Pack 2B;
• no seed/DDL changes.