dot-iu-cutter v0.4 — RealPostgresAdapter Transaction Lifecycle Fix GPT Review

Date: 2026-05-17 Reviewer: GPT Reviewed report: knowledge/dev/laws/dieu44-trien-khai/v0.4-db-adapter-dry-run/dot-iu-cutter-v0.4-realpostgresadapter-txn-lifecycle-fix-completion-report-2026-05-17.md

Verdict

realpostgresadapter_txn_lifecycle_fix: PASS
commit: 6060e1ae8b958fcb8a61ed45b597dc553b8688be
parent: 84c52c57aa296de921998910d85b0d4a85ad0746
defects_found_in_report: false
tests: 110_of_110_PASS
pg_backed_dry_run_may_rerun: true
production_connection_allowed: false
production_secret_read_allowed: false
production_cut_verify_allowed: false
deploy_allowed: false

Accepted Fix

root_defect_fixed: pooled_connection_left_in_implicit_txn_after_out_of_txn_find
find_outside_transaction: rollback_before_pool_return
find_exception: rollback_or_discard_before_pool_return
begin: defensive_rollback_method_before_SET_ISOLATION
begin_failure: rollback_discard_clear_connection
no_global_autocommit_change: true
one_atomic_txn_per_phase_preserved: true
principal_routing_preserved: true
forbidden_SQL_surface_preserved: true

Accepted Tests

test_command: python3 -m unittest discover -s tests
test_result: 110_of_110_PASS
new_tests:
  - tests/test_pg_transaction_lifecycle.py
fake_conn_models_psycopg_25001_rule: true
find_then_transaction_regression_covered: true
find_exception_rollback_covered: true
pooled_connection_clean_reuse_covered: true
transaction_sets_isolation_first_covered: true

Git SSOT / Hardcode Control

repo: /opt/incomex/dot
branch: main
scoped_commit: true
files_changed:
  - iu-cutter/cutter_agent/db_adapter.py
  - iu-cutter/tests/test_real_postgres_adapter.py
  - iu-cutter/tests/test_pg_transaction_lifecycle.py
git_add_A_used: false
unrelated_WIP_committed: false
iu_cutter_status_clean: true
no_hardcode_new_literals: true
no_IP_container_DSN_password_vector_collection_literal: true

Metadata / Label Extensibility Reminder

This adapter fix does not touch information-unit labels/metadata and does not introduce label/key hardcoding. The mandate remains binding:

metadata_label_mandate_still_binding: true
no_runtime_label_key_hardcoding: true
no_new_label_columns_in_this_cycle: true
SQL_SSOT_for_identity_lifecycle_governance_audit: true
JSONB_payload_not_hidden_authority: true
vector_store_not_authority: true
future_label_registry_design_required_before_large_scale_labeling: true

Gate Effect

adapter_txn_lifecycle_fix: closed_PASS
next_allowed_phase: PG_backed_dry_run_rerun
use_code_commit: 6060e1ae8b958fcb8a61ed45b597dc553b8688be
use_verification_plan: r3
expected_final_rows: 15
requires: explicit_execution_prompt

Still forbidden outside isolated dry-run:

forbidden:
  - adapter_connection_to_production_DB
  - production_secret_read
  - production_row_write
  - production_CUT_VERIFY
  - deploy_or_service_restart
  - code_change_or_commit_during_dry_run
  - label_or_metadata_schema_change
  - vector_or_NoSQL_integration

Status

ready_for_PG_backed_dry_run_rerun_prompt: true
agent_self_advance_without_prompt: prohibited