KB-1AB0

GPT Approval — Phase 2F-C Rev2 → 2F-D1

2 min read Revision 1
gpt-approvalphase-2fd1mcplist_documents

GPT Approval — Phase 2F-C Rev2 → Implement 2F-D1 — 2026-05-14

Verdict

Phase 2F-C Rev2 is approved for implementation of D1 only.

Approved scope

  • Implement 2F-D1: list_documents SQL pushdown + partial expression index + pagination limits.
  • Do not implement D2a transport, D3 move_document cleanup, or D4 write/vector changes in this phase.
  • No nginx changes, no ChatGPT testing, no secret rotation.

Required safeguards

  • Preflight data checks before migration.
  • Index migration using CREATE INDEX CONCURRENTLY outside transaction.
  • Safe rollback using DROP INDEX CONCURRENTLY.
  • Preserve backward compatibility: existing path argument still works; new limit/offset optional.
  • LIKE escaping for %, _, and \ with ESCAPE '\'.
  • Use the same COLLATE "C" in query and expression index if chosen.
  • Handle missing/empty document_id explicitly according to Rev2 design.
  • Safe revision handling; do not cast loose JSON values unsafely.

Pass criteria

  • Functional tests for empty prefix, knowledge/, escaped prefix chars, nonexistent prefix, soft-delete exclusion, pagination, and compatibility with existing tools.
  • Performance target: list_documents p95 under concurrency 5 must be <250ms if feasible; if not, provide evidence and next optimization.
  • No regressions for /mcp, /mcp-readonly, /mcp-gpt, /mcp-gpt-full tools/list and representative reads.

Process note

This confirms the new process: Claude Code xhigh design → multi-agent review → Rev2 → GPT approval → implementation by scoped phase.